-
Notifications
You must be signed in to change notification settings - Fork 35
Block interface: refactor #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,294
−2,783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscholak
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Decouple the block interface from the transformer. This will make the SSM interface cleaner, improve readability, prevent bug, simplify the implementation of future mixers, etc. It's also a step towards merging SSMs into the GPT model, and varying block configurations (#242). I also included some groundwork for these tasks, so that upcoming PRs are smaller and simpler.
This PR is pure refactor, and changes that would cause backward compatibility concerns are left for future work.
block
submodule and move everything non-specific to transformers there from thetransformer
directory.BlockConfig
,MLPConfig
,AttentionConfig
fromTransformerConfig
. Using inheritance for backward compatibility, but composition would be preferable.BlockDimNames
,BlockKwargs
from their transformer counterparts for common variables. Use inheritance in their specializations to simplify usage. (Ex. we can systematically useSSMDimNames
,SSMKwargs
when dealing with SSMs.)TensorSpace
entirely, instead create tensor dimensions on the fly. This will both make things simpler and prevent unwanted conflicts between layers with different configs.per_layer_lr_scale
(from incorrect inheritance ofBlockConfig
) andnormalization
fromSSMConfig
, which would cause unexpected behaviour if defined.🔍 Type of change
Select all that apply: